Take both a list of strings and comma separated string in get_roles #6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
marcospri
commented
Aug 26, 2024
|
|
||
| # Pylint is confused about the `in_` for some reason |
There was a problem hiding this comment.
I guess there was some pylint pragma here but not anymore 🤷
LTI1.1 provides a comma separated list of roles while LTI1.3 provides a list. The launch LTIParams provides an abstraction for this, always returning the LTI1.1 version. To allow using get_roles outside a launch context without having to needlessly convert between the two formats allow the method to take roles in both formats.
marcospri
force-pushed
the
refactor-lti-roles-get
branch
from
7ad2a2a
to
9bab49e
Compare
marcospri
commented
Aug 26, 2024
| @@ -22,7 +23,10 @@ def test_get_roles(self, svc, existing_roles): | |||
| role_descriptions.append(existing_roles[0].value) | |||
| role_descriptions.extend(new_roles) | |||
|
|
|||
| roles = svc.get_roles(", ".join(role_descriptions)) | |||
| if roles_as_string: | |||
| # pylint: disable=redefined-variable-type | |||
There was a problem hiding this comment.
Yes, we are redefining the type of a variable here pylint, but that's the point here so adding a disable
acelaya
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
LTI1.1 provides a comma separated list of roles while LTI1.3 provides a list.
The launch LTIParams provides an abstraction for this, always returning the LTI1.1 version.
To allow using get_roles outside a launch context without having to needlessly convert between the two formats allow the method to take roles in both formats.